netdev - Re: [PATCH 3.13.y] nfqueue: Orphan frags in nfqnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+5PVA6tiA_2QEz=yOBWMhwnjhqqTMnNXU439V4zNuO2eq5FWw@mail.gmail.com>
Date:	Tue, 1 Apr 2014 09:40:42 -0400
From:	Josh Boyer <jwboyer@...oraproject.org>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Zoltan Kiss <zoltan.kiss@...rix.com>,
	Thomas Graf <tgraf@...g.ch>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 3.13.y] nfqueue: Orphan frags in nfqnl_zcopy and handle errors

On Sun, Mar 30, 2014 at 7:56 PM, Ben Hutchings <ben@...adent.org.uk> wrote:
> On Fri, 2014-03-28 at 10:29 -0400, Josh Boyer wrote:
>> Backport of upstream commit 36d5fe6a0007 to 3.13.y
>>
>> nfqnl_zcopy can copy elements of the frags array between skbs, but it doesn't
>> orphan them.  Also, it doesn't handle errors, so this patch takes care of that
>> as well, and modify the caller accordingly.  skb_tx_error() is also added to
>> the callers so they will signal the failed delivery towards the creator of the
>> skb.
>>
>> Fixes CVE-2014-2568.
>>
>> Signed-off-by: Zoltan Kiss <zoltan.kiss@...rix.com>
>> Signed-off-by: David S. Miller <davem@...emloft.net>
>> Signed-off-by: Josh Boyer <jwboyer@...oraproject.org>
> [...]
>
> FWIW, I applied the same change to Debian's 3.13.7-1, except for leaving
> 'from' as pointer-to-const.

Thanks for the confirmation, Ben.  I noticed Dave already has the
original patch in his stable bundle on patchwork, so perhaps he's
going to do his own backport.  (Though he has v4 in the bundle and v5
is what went in-tree.)  I figured I would just send mine along in case
it was helpful.

josh
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html