netdev - Re: [PATCH v2 net-next] net: ptp: oki-semi: fix build dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <533ACCCD.8030601@redhat.com>
Date:	Tue, 01 Apr 2014 16:27:25 +0200
From:	Daniel Borkmann <dborkman@...hat.com>
To:	Richard Cochran <richardcochran@...il.com>
CC:	Alexei Starovoitov <ast@...mgrid.com>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] net: ptp: oki-semi: fix build dependency

On 04/01/2014 12:26 AM, Daniel Borkmann wrote:
> On 03/31/2014 08:55 PM, Richard Cochran wrote:
...
>> We don't really need two copies. As long as you are refactoring this,
>> why not reduce it to just one filter?
>>
>> Something like
>>
>> #if defined(CONFIG_PTP_1588_CLOCK) || defined(CONFIG_NETWORK_PHY_TIMESTAMPING)
>>
>> ... code here ...
>>
>> #endif
>>
>> could go into filter.c or somewhere else in the stack.
>
> I'd move that code into it's own file e.g. ptp_classifier.c and while
> at it also remove PTP_FILTER stuff from the header file entirely and
> hide it all locally in that file. I will cook something tomorrow.

Posted at [1], let me know if that is fine with you, Richard.

Thanks !

   [1] http://patchwork.ozlabs.org/patch/335949/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html