netdev - Re: [PATCH net-next 1/1] sxgbe: use common NET_VENDOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67692.1396481743@turing-police.cc.vt.edu>
Date:	Wed, 02 Apr 2014 19:35:43 -0400
From:	Valdis.Kletnieks@...edu
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	Siva Reddy Kallam <siva.kallam@...sung.com>,
	Joe Perches <joe@...ches.com>, netdev@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next 1/1] sxgbe: use common NET_VENDOR_FOO style.

On Thu, 03 Apr 2014 01:13:03 +0200, Francois Romieu said:
> Signed-off-by: Francois Romieu <romieu@...zoreil.com>
> ---
>
>  Valdis, is it what you had in mind ?

Works for me.  That brings it in line with other network drivers, feel free
to stick this on:

Acked-by: Valdis Kletnieks <valdis.kletnieks@...edu>

>  drivers/net/ethernet/samsung/Kconfig       | 24 ++++++++++++++++++++----
>  drivers/net/ethernet/samsung/sxgbe/Kconfig |  9 ---------
>  2 files changed, 20 insertions(+), 13 deletions(-)
>  delete mode 100644 drivers/net/ethernet/samsung/sxgbe/Kconfig
>
> diff --git a/drivers/net/ethernet/samsung/Kconfig b/drivers/net/ethernet/sams
ung/Kconfig
> index 7902341..2360d81 100644
> --- a/drivers/net/ethernet/samsung/Kconfig
> +++ b/drivers/net/ethernet/samsung/Kconfig
> @@ -3,14 +3,30 @@
>  #
>
>  config NET_VENDOR_SAMSUNG
> -	bool "Samsung Ethernet device"
> +	bool "Samsung Ethernet devices"
>  	default y
>  	---help---
> -	  This is the driver for the SXGBE 10G Ethernet IP block found on Samsu
ng
> -	  platforms.
> +	  If you have a network (Ethernet) chipset belonging to this class,
> +	  say Y.
> +
> +	  Note that the answer to this question does not directly affect
> +	  the kernel: saying N will just case the configurator to skip all
> +	  the questions about Samsung chipsets. If you say Y, you will be asked
> +	  for your specific chipset/driver in the following questions.
>
>  if NET_VENDOR_SAMSUNG
>
> -source "drivers/net/ethernet/samsung/sxgbe/Kconfig"
> +config SXGBE_ETH
> +	tristate "Samsung 10G/2.5G/1G SXGBE Ethernet driver"
> +	depends on HAS_IOMEM && HAS_DMA
> +	select PHYLIB
> +	select CRC32
> +	select PTP_1588_CLOCK
> +	---help---
> +	  This is the driver for the SXGBE 10G Ethernet IP block found on
> +	  Samsung platforms.
> +
> +	  To compile this driver as a module, choose M here: the module
> +	  will be called samsung-sxgbe.
>
>  endif # NET_VENDOR_SAMSUNG
> diff --git a/drivers/net/ethernet/samsung/sxgbe/Kconfig b/drivers/net/etherne
t/samsung/sxgbe/Kconfig
> deleted file mode 100644
> index d79288c..0000000
> --- a/drivers/net/ethernet/samsung/sxgbe/Kconfig
> +++ /dev/null
> @@ -1,9 +0,0 @@
> -config SXGBE_ETH
> -	tristate "Samsung 10G/2.5G/1G SXGBE Ethernet driver"
> -	depends on HAS_IOMEM && HAS_DMA
> -	select PHYLIB
> -	select CRC32
> -	select PTP_1588_CLOCK
> -	---help---
> -	  This is the driver for the SXGBE 10G Ethernet IP block found on Samsu
ng
> -	  platforms.
> --
> 1.9.0
>



Content of type "application/pgp-signature" skipped