netdev - Re: [PATCH net-next 3/4] ixgbe: clean up rx time stamping code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1396403154.2230.4.camel@jtkirshe-mobl>
Date:	Tue, 01 Apr 2014 18:45:54 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Jakub Kicinski <kubakici@...pl>
Cc:	netdev@...r.kernel.org, e1000-devel@...ts.sourceforge.net,
	Alexander Duyck <alexander.h.duyck@...el.com>,
	Jacob Keller <jacob.e.keller@...el.com>
Subject: Re: [PATCH net-next 3/4] ixgbe: clean up rx time stamping code

On Wed, 2014-04-02 at 02:52 +0200, Jakub Kicinski wrote:
> Time stamping resources are per-interface so there is no need
> to keep separate last_rx_timestamp for each rx ring, move
> last_rx_timestamp to the adapter structure.
> 
> With last_rx_timestamp inside adapter, ixgbe_ptp_rx_hwtstamp()
> inline function is reduced to a single if statement so it is
> no longer necessary. If statement is placed directly in
> ixgbe_process_skb_fields() fixing likely/unlikely marking.
> 
> Checks for q_vector or adapter to be NULL are superfluous.
> 
> Comment about taking I/O hit is a leftover from previous design.
> 
> Signed-off-by: Jakub Kicinski <kubakici@...pl>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe.h      | 21 ++--------------
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |  3 ++-
>  drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c  | 36
> ++++++++-------------------
>  3 files changed, 15 insertions(+), 45 deletions(-)

Added to my queue, thanks!

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)