netdev - Re: [PATCH net-next v2] vxlan: fix handling of the inner 8021Q tagged frame

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bnwkigay.wl%atzm@stratosphere.co.jp>
Date:	Wed, 02 Apr 2014 12:03:17 +0900
From:	Atzm Watanabe <atzm@...atosphere.co.jp>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, stephen@...workplumber.org
Subject: Re: [PATCH net-next v2] vxlan: fix handling of the inner 8021Q tagged frame


Hi David,

At Tue, 01 Apr 2014 18:19:30 -0400 (EDT),
David Miller wrote:
> 
> From: Atzm Watanabe <atzm@...atosphere.co.jp>
> Date: Tue, 01 Apr 2014 23:27:52 +0900
> 
> > @@ -1215,8 +1257,18 @@ static void vxlan_rcv(struct vxlan_sock *vs,
> >  #endif
> >  	}
> >  
> > +	ether_addr_copy(key.eth_addr, eth_hdr(skb)->h_source);
> > +	switch (ntohs(eth_hdr(skb)->h_proto)) {
> > +	case ETH_P_8021Q:
> > +	case ETH_P_8021AD:
> > +		key.vlan_id = ntohs(vlan_eth_hdr(skb)->h_vlan_TCI) & VLAN_VID_MASK;
> > +		break;
> > +	default:
> > +		key.vlan_id = 0;
> > +	}
>  ...
> > @@ -1983,23 +2056,28 @@ static netdev_tx_t vxlan_xmit(struct sk_buff *skb, struct net_device *dev)
> >  #endif
> >  	}
> >  
> > -	f = vxlan_find_mac(vxlan, eth->h_dest);
> > +	ether_addr_copy(key.eth_addr, eth->h_dest);
> > +	key.vlan_id = vlan_tx_tag_present(skb) ? vlan_tx_tag_get_id(skb) : 0;
> > +
> 
> Now the transmit and receive paths are more expensive, because instead
> of just referring to packet header contents directly, we have to build
> this key structure on the stack.
> 
> Please find a way to do this in a way which avoids this added cost.

Thank you for reviewing.
I understood.  Will fix this to avoid cost that was added by copying header.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html