netdev - Re: [PATCH net-next] sh: add missing fpscr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 02 Apr 2014 09:04:30 +0200
From:	Daniel Borkmann <dborkman@...hat.com>
To:	Alexei Starovoitov <ast@...mgrid.com>
CC:	"David S. Miller" <davem@...emloft.net>,
	Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>,
	Paul Mundt <lethal@...ux-sh.org>,
	Fengguang Wu <fengguang.wu@...el.com>,
	linux-sh@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] sh: add missing fpscr_values

On 04/02/2014 04:54 AM, Alexei Starovoitov wrote:
> GCC on SuperH for the following program:
> int foo(int i)
> {
> 	static const void *table[2] = {
> 		[0] = &&label1,
> 		[1] = &&label2,
> 	};
> 	goto *table[i & 1];
>
> 	label1:
> 		return 1;
> 	label2:
> 		return 2;
> }
> generates code:
> 	mov.l   .L9,r1
> 	mov     #1,r0
> 	rts
> 	lds.l   @r1+,fpscr
> .L9:
> 	.long   __fpscr_values+4
>
> so kernel has to provide body of fpscr_values just like glibc does
>
> Fixes: bd4cf0ed331a ("net: filter: rework/optimize internal BPF interpreter's instruction set")
> Reported-by: Fengguang Wu <fengguang.wu@...el.com>
> Signed-off-by: Alexei Starovoitov <ast@...mgrid.com>
> Cc: Daniel Borkmann <dborkman@...hat.com>

Acked-by: Daniel Borkmann <dborkman@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html