netdev - Re: [PATCH v3 1/5] bonding: Changed hashing function to just provide hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1396435815.3989.23.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 02 Apr 2014 03:50:15 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Mahesh Bandewar <maheshb@...gle.com>
Cc:	Jay Vosburgh <fubar@...ibm.com>,
	Veaceslav Falico <vfalico@...hat.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Maciej Zenczykowski <maze@...gle.com>
Subject: Re: [PATCH v3 1/5] bonding: Changed hashing function to just
 provide hash

On Wed, 2014-04-02 at 00:00 -0700, Mahesh Bandewar wrote:
> Modified the hash function to return just hash separating from the
> modulo operation that can be performed by the caller. This is to
> make way for the tlb mode to use the same hashing policies that
> are used in the 802.3ad and Xor mode.
> 
> Change-Id: I276609e87e0ca213c4d1b17b79c5e0b0f3d0dd6f
> Signed-off-by: Mahesh Bandewar <maheshb@...gle.com>
> ---
> v2:
>   Change the return type of bond_xmit_hash() from int to u32
> v3:
>   Rebase.
> 
>  drivers/net/bonding/bond_3ad.c  |  3 ++-
>  drivers/net/bonding/bond_main.c | 10 ++++------
>  drivers/net/bonding/bonding.h   |  2 +-
>  3 files changed, 7 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c
> index b667a51ed215..ccf2639e916f 100644
> --- a/drivers/net/bonding/bond_3ad.c
> +++ b/drivers/net/bonding/bond_3ad.c
> @@ -30,6 +30,7 @@
>  #include <linux/etherdevice.h>
>  #include <linux/if_bonding.h>
>  #include <linux/pkt_sched.h>
> +#include <net/sock.h>

Not sure why you added this include ?

>  #include <net/net_namespace.h>
>  #include "bonding.h"
>  #include "bond_3ad.h"
> @@ -2440,7 +2441,7 @@ int bond_3ad_xmit_xor(struct sk_buff *skb, struct net_device *dev)
>  		goto err_free;
>  	}
>  
> -	slave_agg_no = bond_xmit_hash(bond, skb, slaves_in_agg);
> +	slave_agg_no = bond_xmit_hash(bond, skb) % slaves_in_agg;
>  	first_ok_slave = NULL;
>  
>  	bond_for_each_slave_rcu(bond, slave, iter) {
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c

Otherwise, seems fine to me

Acked-by: Eric Dumazet <edumazet@...gle.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html