netdev - Re: [PATCH net] net: vxlan: fix crash when interface is created with no group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140403.111914.2151023252588766039.davem@davemloft.net>
Date:	Thu, 03 Apr 2014 11:19:14 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	mike.rapoport@...ellosystems.com
Cc:	dlstevens@...ibm.com, cwang@...pensource.com,
	netdev@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH net] net: vxlan: fix crash when interface is created
 with no group

From: Mike Rapoport <mike.rapoport@...ellosystems.com>
Date: Tue,  1 Apr 2014 09:23:01 +0300

> If the vxlan interface is created without explicit group definition,
> there are corner cases which may cause kernel panic.
> 
> For instance, in the following scenario:
 ...
> When vxlan interface is created without explicit group definition, the
> default_dst protocol family is initialiazed to AF_UNSPEC and the driver
> assumes IPv4 configuration. On the other side, the default_dst protocol
> family is used to differentiate between IPv4 and IPv6 cases and, since,
> AF_UNSPEC != AF_INET, the processing takes the IPv6 path.
> 
> Making the IPv4 assumption explicit by settting default_dst protocol
> family to AF_INET4 and preventing mixing of IPv4 and IPv6 addresses in
> snooped fdb entries fixes the corner case crashes.
> 
> Signed-off-by: Mike Rapoport <mike.rapoport@...ellosystems.com>
> ---
> 
> This can happen starting from 3.12 when IPv6 support was merged to vxlan.

Looks good to me, thanks for following up on this.

Applied and queued up for -stable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html