netdev - Re: [PATCH] net: cpts: Add includes for ETH_HLEN and VLAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140403.123219.186974875530426005.davem@davemloft.net>
Date:	Thu, 03 Apr 2014 12:32:19 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jwboyer@...oraproject.org
Cc:	mugunthanvnm@...com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: cpts: Add includes for ETH_HLEN and VLAN_HLEN
 definitions

From: Josh Boyer <jwboyer@...oraproject.org>
Date: Thu, 3 Apr 2014 12:08:43 -0400

> If CONFIG_TI_CPTS is enabled, the ti_cpsw driver will fail to build with:
> 
> drivers/net/ethernet/ti/cpts.c: In function 'cpts_match':
> drivers/net/ethernet/ti/cpts.c:266:12: error: 'ETH_HLEN' undeclared (first use in this function)
>    offset = ETH_HLEN + IPV4_HLEN(data) + UDP_HLEN;
>             ^
> drivers/net/ethernet/ti/cpts.c:266:12: note: each undeclared identifier is reported only once for each function it appears in
> drivers/net/ethernet/ti/cpts.c:276:23: error: 'VLAN_HLEN' undeclared (first use in this function)
>    offset = ETH_HLEN + VLAN_HLEN;
>                        ^
> 
> Add includes of if_ether.h and if_vlan.h to bring in the appropriate defines.
> 
> Signed-off-by: Josh Boyer <jwboyer@...oraproject.org>

A patch for this was already submitted to netdev and applied to the 'net'
GIT tree earlier today.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html