netdev - Re: [Patch net-next] pktgen: small code cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140403.133525.1594438930436435429.davem@davemloft.net>
Date:	Thu, 03 Apr 2014 13:35:25 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	weiyang@...ux.vnet.ibm.com
Cc:	fan.du@...driver.com, netdev@...r.kernel.org
Subject: Re: [Patch net-next] pktgen: small code cleanup

From: Wei Yang <weiyang@...ux.vnet.ibm.com>
Date: Wed,  2 Apr 2014 16:24:51 +0800

> Print the warning when the format is not correct.
> 
> Signed-off-by: Wei Yang <weiyang@...ux.vnet.ibm.com>
> ---
>  net/core/pktgen.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/core/pktgen.c b/net/core/pktgen.c
> index fdac61c..89d33c2 100644
> --- a/net/core/pktgen.c
> +++ b/net/core/pktgen.c
> @@ -1767,7 +1767,7 @@ static ssize_t pktgen_thread_write(struct file *file,
>  	char *pg_result;
>  
>  	if (count < 1) {
> -		//      sprintf(pg_result, "Wrong command format");
> +		pr_warn("WARNING: Wrong command format in %s\n", __func__);
>  		return -EINVAL;
>  	}
>  

I don't think a kernel log message is appropriate.

The intention, as per the comment protected code, was to make this
error message show up in show_results()'s output.

I'm not applying this, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html