lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 4 Apr 2014 10:10:59 +0300
From:	Claudiu Manoil <claudiu.manoil@...escale.com>
To:	<roy.qing.li@...il.com>, <netdev@...r.kernel.org>
CC:	<Yanjun.Zhu@...driver.com>
Subject: Re: [PATCH] Documentation: document the gianfar tx vlan offload issue

On 4/4/2014 10:07 AM, Claudiu Manoil wrote:
> On 4/4/2014 6:04 AM, roy.qing.li@...il.com wrote:
>> From: Li RongQing <roy.qing.li@...il.com>
>>
>> The commit b852b72087[gianfar: fix bug caused by 87c288c6e9] and
>> e2c53be223
>> [gianfar: fix default tx vlan offload feature flag] disabled tx vlan
>> offload
>> from dev->feature, since enabling vlan tag insertion leads to unusable
>> connections on some configurations.
>>
>> But this feature is in dev->hw_feature still, and a user can enable it by
>> "ethtool", so document the tx vlan offload issue.
>>
>> Signed-off-by: Li RongQing <roy.qing.li@...il.com>
>> Signed-off-by: Zhu Yanjun <Yanjun.Zhu@...driver.com>
>> Cc: Claudiu Manoil <claudiu.manoil@...escale.com>
>> ---
>>   Documentation/networking/gianfar.txt |   12 ++++++++++++
>>   1 file changed, 12 insertions(+)
>>
>> diff --git a/Documentation/networking/gianfar.txt
>> b/Documentation/networking/gianfar.txt
>> index ad474ea..2d3dbe6 100644
>> --- a/Documentation/networking/gianfar.txt
>> +++ b/Documentation/networking/gianfar.txt
>> @@ -51,6 +51,18 @@ configuring VLANs.  The gianfar driver supports
>> hardware insertion and
>>   extraction of VLAN headers, but not filtering.  Filtering will be
>>   done by the kernel.
>> +But if tx vlan tag hardware insertion is enabled, and a vlan-device is
>> +created, the physical device which vlan device is on will be unable to
>> +work, like:
>> +
>> +    $ethtool -K eth0 tx-vlan-stag-hw-insert on
>> +    $ifconfig eth0 192.168.1.13/24 up
>> +
>> +    $vconfig add eth0 4091
>> +    $ifconfig eth0.4091 10.1.1.13/24 up
>> +eth0.4091 can work, but eth0 can not work, since eth0 sends the insane
>> +packets out.
>> +
> I don't really like this, this is hardly a technical explanation.
> ("insane packets"?)
> Please have a look at the HW reference manual.  There you have the
> description
> of the VLAN extraction feature (see VLEX).
>
And VLAN insertion (VLINS) as well, for that matter.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists