netdev - Re: i40e: Add code to handle FD table full condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 4 Apr 2014 10:59:30 -0400
From:	Dave Jones <davej@...hat.com>
To:	netdev@...r.kernel.org
Cc:	anjali.singhai@...el.com, jeffrey.t.kirsher@...el.com
Subject: Re: i40e: Add code to handle FD table full condition

On Thu, Apr 03, 2014 at 05:20:19AM +0000, Linux Kernel wrote:
 > Gitweb:     http://git.kernel.org/linus/;a=commit;h=55a5e60b9f583f64a6c95cfe869dd2d65ae53a95
 > Commit:     55a5e60b9f583f64a6c95cfe869dd2d65ae53a95
 > Parent:     61dade7e9201162cba683cff103cebbdf06655d4
 > Author:     Anjali Singhai Jain <anjali.singhai@...el.com>
 > AuthorDate: Wed Feb 12 06:33:25 2014 +0000
 > Committer:  Jeff Kirsher <jeffrey.t.kirsher@...el.com>
 > CommitDate: Fri Mar 14 16:30:03 2014 -0700
 > 
 >     i40e: Add code to handle FD table full condition
 
...

 > +			/* Turn off ATR first */
 > +			if (pf->flags | I40E_FLAG_FD_ATR_ENABLED) {

This condition is always true.
Did you mean to write something like

	if (pf->flags & ~I40E_FLAG_FD_ATR_ENABLED)

perhaps ?

Same with the 

	} else if (pf->flags | I40E_FLAG_FD_SB_ENABLED) {

that pairs with it.


	Dave

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html