lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Fri, 04 Apr 2014 15:22:41 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Vlad Yasevich <vyasevic@...hat.com>
Cc:	netdev@...r.kernel.org, e1000-devel@...ts.sourceforge.net
Subject: Re: [PATCH net] e1000e: Correctly include VLAN_HLEN when changing
 interface MTU

On Fri, 2014-04-04 at 16:48 -0400, Vlad Yasevich wrote:
> When changing the interface mtu, the driver starts with a value
> that doesn't include VLAN_HLEN.  Later tests in the driver
> set the rx_buffer_len based on the mtu.  As a result, when
> the user increases the mtu to 1504 (to support 802.1AD for example),
> the driver rx_buffer_len does not change and frames longer
> the 1522 bytes are rejected as too long.
> 
> Include VLAN_HLEN from the start so that an user mtu greater then
> 1500 bytes is correctly reflected in the driver rx_buffer_len.
> 
> CC: e1000-devel@...ts.sourceforge.net
> CC: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Signed-off-by: Vlad Yasevich <vyasevic@...hat.com>
> ---
>  drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks Vlad, I will add the patch to my queue.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)

Powered by blists - more mailing lists