netdev - Re: linux-next: Tree for Apr 1 (netfilter)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140406.113106.564835222660199498.davem@davemloft.net>
Date:	Sun, 06 Apr 2014 11:31:06 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	geert@...ux-m68k.org
Cc:	rdunlap@...radead.org, sfr@...b.auug.org.au,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: linux-next: Tree for Apr 1 (netfilter)

From: Geert Uytterhoeven <geert@...ux-m68k.org>
Date: Sun, 6 Apr 2014 15:50:04 +0200

> On Tue, Apr 1, 2014 at 9:22 PM, David Miller <davem@...emloft.net> wrote:
>> From: Randy Dunlap <rdunlap@...radead.org>
>> Date: Tue, 01 Apr 2014 11:34:15 -0700
>>
>>> on x86_64:
>>>
>>> net/netfilter/xt_connlimit.c: In function 'connlimit_mt_check':
>>> net/netfilter/xt_connlimit.c:380:18: warning: division by zero [-Wdiv-by-zero]
>>>
>>> Maybe just use CONNLIMIT_LOCK_SLOTS instead of ARRAY_SIZE(...).
>>
>> I'd rather see that ARRAY_SIZE() be adjusted to work cleanly for zero
>> sized array elements.
> 
> Anyone with a suggestion?
> 
> Please note this is now in Linus' tree, possibly crashing people's boxes...

I took in the version of the fix I didn't like via Pablo for
now.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html