netdev - RE: [PATCH net 1/2] sxgbe: fix duplicate #include headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 07 Apr 2014 18:46:49 +0900
From:	Byungho An <bh74.an@...sung.com>
To:	'Jean Sacren' <sakiwit@...il.com>, netdev@...r.kernel.org
Cc:	'Girish K S' <ks.giri@...sung.com>,
	'Siva Reddy Kallam' <siva.kallam@...sung.com>,
	'Vipul Pandya' <vipul.pandya@...sung.com>
Subject: RE: [PATCH net 1/2] sxgbe: fix duplicate #include headers

Jean Sacren wrote:
> 
> The commit 1edb9ca69e8a ("net: sxgbe: add basic framework for
> Samsung 10Gb ethernet driver") added support for Samsung 10Gb
> ethernet driver(sxgbe) with a minor issue of including linux/io.h
> header twice in sxgbe_dma.c file. Fix the duplicate #include by
> deleting the top one so that all the rest good #include headers
> would be preserved in the alphabetical order.
> 
> Signed-off-by: Jean Sacren <sakiwit@...il.com>
> Cc: Byungho An <bh74.an@...sung.com>

Acked-by: Byungho An <bh74.an@...sung.com>

Thanks,
Byungho

> Cc: Girish K S <ks.giri@...sung.com>
> Cc: Siva Reddy Kallam <siva.kallam@...sung.com>
> Cc: Vipul Pandya <vipul.pandya@...sung.com>
> ---
>  drivers/net/ethernet/samsung/sxgbe/sxgbe_dma.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_dma.c
> b/drivers/net/ethernet/samsung/sxgbe/sxgbe_dma.c
> index 28f89c41d0cd..4d989ff6c978 100644
> --- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_dma.c
> +++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_dma.c
> @@ -9,7 +9,6 @@
>   * it under the terms of the GNU General Public License version 2 as
>   * published by the Free Software Foundation.
>   */
> -#include <linux/io.h>
>  #include <linux/delay.h>
>  #include <linux/export.h>
>  #include <linux/io.h>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html