lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 7 Apr 2014 22:23:34 +0800
From:	Herbert Xu <>
To:	Eric Dumazet <>
Cc:	"David S. Miller" <>,
Subject: Re: [PATCH 2/2] macvlan: Move broadcasts into a work queue

On Mon, Apr 07, 2014 at 07:07:42AM -0700, Eric Dumazet wrote:
> I suppose its a net-next material ?

Oh yes absolutely.

> Memory allocations (one incoming message -> ~4096 duplications) probably
> should use GFP_KERNEL. This might need a change from rcu to simple mutex
> for macvlan_broadcast() scan of all macvlans.

Good point.  However, as this change will be non-trivial we can
do this as a follow-up.

> cond_resched() could help macvlan_process_broadcast() to not hog cpu.
> Anyway, 4.000 incoming messages are duplicated into 16.000.000 messages,
> it takes half a minute to process on a single cpu. You might need
> multiple workqueue to split the load on all online cpus ;)

You're welcome to add further improvements :)

Email: Herbert Xu <>
Home Page:
PGP Key:
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists