netdev - Re: [PATCH net-next 3/6] net: Generalize checksum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140407.131241.254964708720144041.davem@davemloft.net>
Date:	Mon, 07 Apr 2014 13:12:41 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	therbert@...gle.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 3/6] net: Generalize checksum_init functions

From: Tom Herbert <therbert@...gle.com>
Date: Fri, 4 Apr 2014 17:27:19 -0700 (PDT)

> +static inline __sum16 skb_checksum_init(struct sk_buff *skb, int proto,
> +		__wsum (*compute_pseudo)(struct sk_buff *skb, int proto)) {

Please Tom put the openning braces on a seperate line.

This goes for all of the new inlines you've created here.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html