lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 07 Apr 2014 14:56:05 -0400 (EDT) From: David Miller <davem@...emloft.net> To: zhangfei.gao@...aro.org Cc: linux@....linux.org.uk, arnd@...db.de, f.fainelli@...il.com, sergei.shtylyov@...entembedded.com, mark.rutland@....com, David.Laight@...LAB.COM, eric.dumazet@...il.com, linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org, devicetree@...r.kernel.org Subject: Re: [PATCH 3/3] net: hisilicon: new hip04 ethernet driver From: Zhangfei Gao <zhangfei.gao@...aro.org> Date: Sat, 5 Apr 2014 12:35:06 +0800 > +#define DESC_DEF_CFG 0x14 You absolutely cannot do this. You must document what the bits in the TX descriptor config field mean, all of them. I bet there is a bit in there somewhere which tells the chip to signal an interrupt when the packet has been sent. But since you haven't documented the descriptor fields properly with a full set of macro defines, we can't know what bit that is. I really am very disappointed in the quality of this driver, and you can expect that there will be a lot of push back and requests for changes before this driver will be even close to being ready for inclusion. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists