netdev - Re: net/l2tp/l2tp_ppp.c should take pmtu from tunnel socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140407.150730.744205365492439471.davem@davemloft.net>
Date:	Mon, 07 Apr 2014 15:07:30 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dmgenp@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: net/l2tp/l2tp_ppp.c should take pmtu from tunnel socket

From: Dmitry Petukhov <dmgenp@...il.com>
Date: Sun, 6 Apr 2014 00:58:27 +0600

> currently when it tries to get PMTU, it does
> 
> dst = sk_dst_get(sk);
> ...
> u32 pmtu = dst_mtu(__sk_dst_get(sk));
> 
> where sk represents PPPoX socket
> 
> it should use tunnel UDP socket instead, tunnel->sock
> 
> This bug bite me when I tried to use l2tp vpn over the link with mtu <
> 1500 but where fragments were dropped somewere along the path. I tried
> to use this mechanism with
> 
> ip route add <dst> via ... mtu <lower_mtu>
> 
> but it didn't work.
> 
> After the fix I was able to use this feature of l2tp_ppp driver, it
> picked up mtu set by ip route and used it.
> 
> patch against https://github.com/torvalds/linux master:

This is not a proper patch submission, please read Documentation/SubmittingPatches
to learn how to do it properly.

In particular, you need to provide a proper patch signoff.

Please do not reply to this thread with the updated patch submission,
instead make a new, fresh, list posting following the patch submission
rules.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html