netdev - Re: [PATCH net] netdev: remove potentially harmful checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140407.155246.1115800673081965447.davem@davemloft.net>
Date:	Mon, 07 Apr 2014 15:52:46 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	vfalico@...hat.com
Cc:	netdev@...r.kernel.org, dborkman@...hat.com, edumazet@...gle.com,
	nicolas.dichtel@...nd.com, jiri@...nulli.us,
	stephen@...workplumber.org, hkchu@...gle.com
Subject: Re: [PATCH net] netdev: remove potentially harmful checks

From: Veaceslav Falico <vfalico@...hat.com>
Date: Mon,  7 Apr 2014 11:25:12 +0200

> Currently we're checking a variable for != NULL after actually
> dereferencing it, in netdev_lower_get_next_private*().
> 
> It's counter-intuitive at best, and can lead to faulty usage (as it implies
> that the variable can be NULL), so fix it by removing the useless checks.
> 
> Reported-by: Daniel Borkmann <dborkman@...hat.com>
> CC: "David S. Miller" <davem@...emloft.net>
> CC: Eric Dumazet <edumazet@...gle.com>
> CC: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> CC: Jiri Pirko <jiri@...nulli.us>
> CC: stephen hemminger <stephen@...workplumber.org>
> CC: Jerry Chu <hkchu@...gle.com>
> Signed-off-by: Veaceslav Falico <vfalico@...hat.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html