netdev - Re: ipv6: Should inet6_addr_del consider IFA_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 Apr 2014 22:14:30 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Heiner Kallweit <heiner.kallweit@....de>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	jiri@...nulli.us, thaller@...hat.com
Subject: Re: ipv6: Should inet6_addr_del consider IFA_F_MANAGETEMPADDR?

[cc Jiri + Thomas]

Hi!

On Tue, Apr 08, 2014 at 08:26:37PM +0200, Heiner Kallweit wrote:
> I stumbled accross the fact that inet6_addr_add as well as inet6_addr_modify
> consider IFA_F_TEMPORARY whilst inet6_addr_del does not.
> 
> My understanding of IFA_F_MANAGETEMPADDR is that it allows userspace applications
> to deal with temporary addresses w/o having to create / track (and possibly delete)
> each and every temporary address.
> 
> This works fine when creating / modifying a global address. However when a
> global address is deleted the orphaned temporary addresses remain.
> Shouldn't the userspace be able to set IFA_F_MANAGETEMPADDR also for RTM_DELADDR
> to signalize that the kernel should delete all related temporary addresses as well?

Sure, that is possible. I guess it was not done already because
inet6_addr_del did not handle IFA_FLAGS at all. But it should be a very
tiny change to pass that flag down. Please submit an iproute patch along
with your changes.

> It would be a rather small extension to manage_tempaddrs to add a "delete" parameter
> and set valid_lft=prefered_lft=0 for each temporary address if set.

I think valid_lft=prefered_lft=0; manage_tempaddr(...);
addrconf_verify_rtnl(); is enough to clean up the old temporary address.
No need for a further flag.

> Sorry if this was discussed before and I miss something.

I don't remember a discussion about that. ;)

Bye,

  Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html