lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 08 Apr 2014 16:43:56 -0400 (EDT)
From:	David Miller <>
Subject: Re: [Patch net] ipv4: fib: check forwarding before checking

From: Cong Wang <>
Date: Tue,  8 Apr 2014 12:31:22 -0700

> From: Cong Wang <>
> We have seen in a weird case we had to disable send_redirects in order
> to pass rp filter check even though we don't set forwarding at all.
> This looks wrong, at least according to ip-sysctl.txt send_redirects should
> only make sense when we enable forwarding.
> Cc: Eric Biederman <>
> Cc: Julian Anastasov <>
> Cc: David S. Miller <>
> Signed-off-by: Cong Wang <>
> Signed-off-by: Cong Wang <>

I'm not so sure about this.

This test here is just an optimization, which bypasses the long path
processing of FIB source address validation if certain strict
conditions are met.

__fib_validate_source() should do the right thing if it is executed,
it is just the slow path, and you should determine why it is rejecting
your traffic instead.

Your change is a valid optimization perhaps, but not a bug fix.
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists