netdev - Re: [PATCH net-next 2/2] ptp: Fix compiler warnings in the testptp utility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C5B090FABC863EF2D36D89C3@[172.22.2.41]>
Date:	Wed, 09 Apr 2014 08:40:59 +0200
From:	Christian Riesch <christian.riesch@...il.com>
To:	"Keller, Jacob E" <jacob.e.keller@...el.com>,
	Richard Cochran <richardcochran@...il.com>
cc:	Christian Riesch <christian.riesch@...cron.at>,
	netdev@...r.kernel.org, Dong Zhu <bluezhudong@...il.com>
Subject: Re: [PATCH net-next 2/2] ptp: Fix compiler warnings in the testptp
 utility



--On April 08, 2014 21:43 +0000 "Keller, Jacob E" 
<jacob.e.keller@...el.com> wrote:

> On Tue, 2014-03-25 at 12:45 +0100, Richard Cochran wrote:
>> On Tue, Mar 25, 2014 at 12:24:06PM +0100, Christian Riesch wrote:
>> > Signed-off-by: Christian Riesch <christian.riesch@...cron.at>
>> > Cc: Dong Zhu <bluezhudong@...il.com>
>> > ---
>> >  Documentation/ptp/testptp.c |   10 +++++-----
>> >  1 file changed, 5 insertions(+), 5 deletions(-)
>> >
>> > diff --git a/Documentation/ptp/testptp.c b/Documentation/ptp/testptp.c
>> > index 13bddd5..14bf19e 100644
>> > --- a/Documentation/ptp/testptp.c
>> > +++ b/Documentation/ptp/testptp.c
>> > @@ -496,14 +496,14 @@ int main(int argc, char *argv[])
>> >  			interval = t2 - t1;
>> >  			offset = (t2 + t1) / 2 - tp;
>> >
>> > -			printf("system time: %ld.%ld\n",
>> > +			printf("system time: %lld.%u\n",
>> >  				(pct+2*i)->sec, (pct+2*i)->nsec);
>> > -			printf("phc    time: %ld.%ld\n",
>> > +			printf("phc    time: %lld.%u\n",
>> >  				(pct+2*i+1)->sec, (pct+2*i+1)->nsec);
>> > -			printf("system time: %ld.%ld\n",
>> > +			printf("system time: %lld.%u\n",
>> >  				(pct+2*i+2)->sec, (pct+2*i+2)->nsec);
>> > -			printf("system/phc clock time offset is %ld ns\n"
>> > -				"system     clock time delay  is %ld ns\n",
>>
>> Use PRId64 instead?
>>
>> Thanks,
>> Richard
>>
>
> I agree with this. %lld is not going to resolve the error properly on a
> 32 bit machine. Looks like a follow-on patch would have to be generated,
> since Dave applied this already.

I checked again, no follow-up patch is required: David first applied v1 
(commit 203191c386e83b8c5d95bbbaef13baa629512726), later reverted it 
(031fe792ccd4f5d79415b219c73b868da98d9b70), and applied v2 
(4ec54f95736f2d90e4d9e4fcc75cf1228f0f3ede).

Thanks, Christian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html