netdev - Re: [net PATCH 1/1] drivers: net: cpsw: Add default vlan for dual emac case also

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGm1_ku3Fc=Lh8K17M=PCZT491KP-UvFR0BE6mvb5zrr8ybc9Q@mail.gmail.com>
Date:	Wed, 9 Apr 2014 15:42:33 +0200
From:	Yegor Yefremov <yegorslists@...glemail.com>
To:	Mugunthan V N <mugunthanvnm@...com>
Cc:	netdev <netdev@...r.kernel.org>, David Miller <davem@...emloft.net>
Subject: Re: [net PATCH 1/1] drivers: net: cpsw: Add default vlan for dual
 emac case also

On Wed, Apr 9, 2014 at 8:04 AM, Mugunthan V N <mugunthanvnm@...com> wrote:
> Dual EMAC works with VLAN segregation of the ports, so default vlan needs
> to be added in dual EMAC case else default vlan will be tagged for all
> egress packets and vlan unaware switches/servers will drop packets
> from the EVM.
>
> Signed-off-by: Mugunthan V N <mugunthanvnm@...com>
> ---
>  drivers/net/ethernet/ti/cpsw.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index 5d5fec6..6133e4a 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -1201,8 +1201,7 @@ static int cpsw_ndo_open(struct net_device *ndev)
>         for_each_slave(priv, cpsw_slave_open, priv);
>
>         /* Add default VLAN */
> -       if (!priv->data.dual_emac)
> -               cpsw_add_default_vlan(priv);
> +       cpsw_add_default_vlan(priv);
>
>         if (!cpsw_common_res_usage_state(priv)) {
>                 /* setup tx dma to fixed prio and zero offset */
> --
> 1.9.0

Tested-by: Yegor Yefremov <yegorslists@...glemail.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html