lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Tue, 08 Apr 2014 22:06:00 -0400 (EDT)
From:	David Miller <>
Subject: Re: [PATCH] net: core: don't account for udp header size when
 computing seglen

From: Florian Westphal <>
Date: Tue,  8 Apr 2014 22:51:28 +0200

> In case of tcp, gso_size contains the tcpmss.
> For UFO (udp fragmentation offloading) skbs, gso_size is the fragment
> payload size, i.e. we must not account for udp header size.
> Otherwise, when using virtio drivers, a to-be-forwarded UFO GSO packet
> will be needlessly fragmented in the forward path, because we think its
> individual segments are too large for the outgoing link.
> Fixes: de960aa9ab4d ("net: add and use skb_gso_transport_seglen()")
> Cc: Eric Dumazet <>
> Reported-by: Tobias Brunner <>
> Signed-off-by: Florian Westphal <>

I agree completely with the fix, but not necessarily with the Fixes:

All that commit did was move the code to a common location, it
always had this bug.

I suppose you could list the subsequent commit, the one that started
using this helper in the IP forwarding code, as what this "Fixes".

Thanks Florian.
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists