netdev - Re: [PATCH 3/3] staging: r8712u: Fix case where ethtype was never obtained and always be checked against 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53458743.70008@lwfinger.net>
Date:	Wed, 09 Apr 2014 12:45:39 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	gregkh@...uxfoundation.org
CC:	netdev@...r.kernel.org, devel@...verdev.osuosl.org,
	Stable <stable@...r.kernel.org>
Subject: Re: [PATCH 3/3] staging: r8712u: Fix case where ethtype was never
 obtained and always be checked against 0

On 04/09/2014 11:25 AM, Sergei Shtylyov wrote:
> On 04/09/2014 08:13 PM, Larry Finger wrote:
>
>> Zero-initializing ether_type masked that the ether type would never be
>> obtained for 8021x packets and the comparition against eapol_type
>> would always fail.
>
>> Reported-by: Jes Sorensen <Jes.Sorensen@...hat.com>
>> Signed-off-by: Larry Finger <Larry.Finger@...inger.net>
>> Cc: Stable <stable@...r.kernel.org>
>> ---
>>   drivers/staging/rtl8712/rtl871x_recv.c | 15 +++++++--------
>>   1 file changed, 7 insertions(+), 8 deletions(-)
>
>> diff --git a/drivers/staging/rtl8712/rtl871x_recv.c
>> b/drivers/staging/rtl8712/rtl871x_recv.c
>> index 23ec684..d8d1a76 100644
>> --- a/drivers/staging/rtl8712/rtl871x_recv.c
>> +++ b/drivers/staging/rtl8712/rtl871x_recv.c
> [...]
>> @@ -262,16 +262,15 @@ union recv_frame *r8712_portctrl(struct _adapter *adapter,
>>       psta_addr = pfhdr->attrib.ta;
>>       psta = r8712_get_stainfo(pstapriv, psta_addr);
>>       auth_alg = adapter->securitypriv.AuthAlgrthm;
>> -    if (auth_alg == 2) {
>> +    if (auth_alg == dot11AuthAlgrthm_8021X) {
>> +        /* get ether_type */
>> +        ptr = ptr + pfhdr->attrib.hdrlen + LLC_HEADER_SIZE;
>
>     Why not:
>
>          ptr += pfhdr->attrib.hdrlen + LLC_HEADER_SIZE;

My comment is the same as the one I sent for patch 2.

Larry


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html