netdev - Re: [PATCH 2/3] staging: r8188eu: Fix case where ethtype was never obtained and always be checked against 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53459B78.7090709@cogentembedded.com>
Date:	Wed, 09 Apr 2014 23:11:52 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	Larry Finger <Larry.Finger@...inger.net>,
	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	netdev@...r.kernel.org, Stable <stable@...r.kernel.org>
Subject: Re: [PATCH 2/3] staging: r8188eu: Fix case where ethtype was never
 obtained and always be checked against 0

On 04/09/2014 11:02 PM, Dan Carpenter wrote:

>>> diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c b/drivers/staging/rtl8188eu/core/rtw_recv.c
>>> index 01fcabc..61084d6 100644
>>> --- a/drivers/staging/rtl8188eu/core/rtw_recv.c
>>> +++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
>>> @@ -551,7 +551,7 @@ static struct recv_frame *portctrl(struct adapter *adapter,
>>>   	struct sta_info *psta;
>>>   	struct sta_priv *pstapriv;
>>>   	struct recv_frame *prtnframe;
>>> -	u16	ether_type = 0;
>>> +	u16	ether_type;

>>     I suggest:

>> 	u16 ethertype;

> I don't understand this suggestion.  Why is that name prefered?

    Sorry, I've managed to somehow remove the underscore. :-/
My real suggestion was to replace the tab with a space.

> regards,
> dan carpenter

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html