lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 10 Apr 2014 13:23:18 +0300 From: Vladimir Kondratiev <qca_vkondrat@....qualcomm.com> To: Michal Marek <mmarek@...e.cz> CC: Joe Perches <joe@...ches.com>, "John W . Linville" <linville@...driver.com>, <linux-wireless@...r.kernel.org>, <wil6210@....qualcomm.com>, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH 1/5] wil6210: Convert to Kbuild On Thursday, April 10, 2014 10:22:47 AM Michal Marek wrote: > On 2014-04-09 18:06, Joe Perches wrote: > > (adding Michal Marek) > > > > On Wed, 2014-04-09 at 17:08 +0300, Vladimir Kondratiev wrote: > >> On Tuesday, April 08, 2014 09:14:51 AM Joe Perches wrote: > >>> On Tue, 2014-04-08 at 11:36 +0300, Vladimir Kondratiev wrote: > >>>> Convert Makefile -> Kbuild, > >>>> to make off-kernel development easier and less intrusive. > >>> No drivers/net directory uses Kbuild. > >>> Why should this? > >> > >> because it makes it easier to do off-kernel development, and then > >> move things to the proper location within the kernel without > >> conflicting changes in the Makefile. > > You can create a GNUmakefile for this purpose, it takes precedence over > Makefile. > > > >> As I understand, Kbuild is better choice because it is really not > >> standalone "Makefile", it is intended to be included by the real > >> Makefile. Thus, distinct name is better. > >> Are there any reasons why not using Kbuild? I did not found > >> guidelines when use Kbuild and when not. > > Kbuild is a slightly better choice because it better describes the > content, but I don't think its needed to rename existing Makefiles just > because of that. Kbuild is needed in the toplevel directory or in > arch/*/, where Makefile has a different special meaning. The out of tree > build use case can be solved by a GNUmakefile. > Originally, I followed the code found at drivers/scsi/osd/ They have Kbuild for in-kernel use and Makefile for out-of-tree But now I found, Documentation/kbuild/makefiles.txt says: ---cut--- The preferred name for the kbuild files are 'Makefile' but 'Kbuild' can be used and if both a 'Makefile' and a 'Kbuild' file exists, then the 'Kbuild' file will be used. ---cut--- Accordingly to this, would you say I should drop this patch and go with GNUmakefile + Makefile for internal development? I am pretty neutral with this, just need to know what is the proper way. Thanks, Vladimir -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists