netdev - Re: [PATCH V1 net] net/mlx4_core: Preserve pci_dev_data after __mlx4_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Apr 2014 15:33:55 +0300
From:	Jack Morgenstein <jackm@....mellanox.co.il>
To:	Wei Yang <weiyang@...ux.vnet.ibm.com>
Cc:	linux-pci@...r.kernel.org, netdev@...r.kernel.org,
	davem@...emloft.net, Bjorn Helgaas <bhelgaas@...gle.com>,
	Amir Vadai <amirv@...lanox.com>,
	Or Gerlitz <ogerlitz@...lanox.com>
Subject: Re: [PATCH V1 net] net/mlx4_core: Preserve pci_dev_data after
 __mlx4_remove_one()

On Thu, 10 Apr 2014 17:25:24 +0800
Wei Yang <weiyang@...ux.vnet.ibm.com> wrote:

> pci_match_id() just match the static pci_device_id, which may return
> NULL if someone binds the driver to a device manually using
> /sys/bus/pci/drivers/.../new_id.
> 
> This patch wrap up a helper function __mlx4_remove_one() which does
> the tear down function but preserve the drv_data. Functions like
> mlx4_pci_err_detected() and mlx4_restart_one() will call this one
> with out releasing drvdata.
> 
> Fixes: 97a5221 "net/mlx4_core: pass pci_device_id.driver_data to
> __mlx4_init_one during reset".
> 
> CC: Bjorn Helgaas <bhelgaas@...gle.com>
> CC: Amir Vadai <amirv@...lanox.com>
> CC: Jack Morgenstein <jackm@....mellanox.co.il>
> CC: Or Gerlitz <ogerlitz@...lanox.com>
> Signed-off-by: Wei Yang <weiyang@...ux.vnet.ibm.com>

  Acked-by: Jack Morgenstein <jackm@....mellanox.co.il>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html