netdev - Re: Does IPv6 support Jumbograms ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140410235459.GK27255@order.stressinduktion.org>
Date:	Fri, 11 Apr 2014 01:54:59 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Francois WELLENREITER <f.wellenreiter@...il.com>,
	netdev@...r.kernel.org
Subject: Re: Does IPv6 support Jumbograms ?

On Wed, Apr 09, 2014 at 05:36:10PM -0700, Eric Dumazet wrote:
> On Thu, 2014-04-10 at 00:35 +0200, Hannes Frederic Sowa wrote:
> > On Wed, Apr 09, 2014 at 02:41:05PM -0700, Eric Dumazet wrote:
> > > What do you mean by blocked ?
> > > 
> > > Please give more details (kernel version, exact mtu...), because it
> > > should not happen !
> > > 
> > > # ifconfig lo mtu 100000
> > > # scp -6 vmlinux edumazet@...-localhost:/tmp
> > > Password: 
> > > vmlinux
> > > 100%   24MB  23.5MB/s   00:00    
> > > # ls -l /tmp/vmlinux
> > > -rwxr-xr-x 1 edumazet eng 24668915 Apr  9 14:37 /tmp/vmlinux
> > 
> > I couldn't test it on my development system with a recent net-next kernel
> > yet, but on my laptop with a distribution 3.13.9 kernel this happened too.
> 
> Oh well, it seems ip6_mtu() needs to cap mtu to max mtu for non
> jumbograms...
> 
> -	return mtu;
> +	return min_t(unsigned int, mtu, IP6_MAX_MTU);
> 
> #define IP6_MAX_MTU (65535 + 40)

                             ^ minus

I think we should do that. Otherwise we would have to start supporting
jumbograms in the output path generally.

Greetings,

  Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html