netdev - Re: [PATCH] net: sun4i-emac: add promiscuous support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Apr 2014 11:55:50 +0200
From:	Stefan Roese <sr@...x.de>
To:	Marc Zyngier <marc.zyngier@....com>, linux-sunxi@...glegroups.com,
	netdev@...r.kernel.org
CC:	Maxime Ripard <maxime.ripard@...e-electrons.com>
Subject: Re: [PATCH] net: sun4i-emac: add promiscuous support

On 11.04.2014 11:46, Marc Zyngier wrote:
> The sun4i-emac driver is rather primitive, and doesn't support
> promiscuous mode. This makes usage such as bridging impossible,
> which is a shame on virtualization capable HW such as the
> Allwinner A20.
>
> The fix is fairly simple: move the RX setup code to the ndo_set_rx_mode
> vector, and add the required HW configuration when IFF_PROMISC is passed
> by the core code.
>
> This has been tested on a generic A20 box running a few virtual
> machines hanging off a bridge with the EMAC chip as the link to the
> outside world.
>
> Cc: Stefan Roese <sr@...x.de>
> Cc: Maxime Ripard <maxime.ripard@...e-electrons.com>
> Signed-off-by: Marc Zyngier <marc.zyngier@....com>

Looks good, so:

Acked-by: Stefan Roese <sr@...x.de>

Thanks,
Stefan

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html