netdev - Re: [Patch iproute2] u32: add terminal parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpU7Ntn-yo-ez0vP2BhKe+-Vaq1w_+MQhFPHM-bbQZx2gg@mail.gmail.com>
Date:	Fri, 11 Apr 2014 18:15:19 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>
Subject: Re: [Patch iproute2] u32: add terminal parameter

On Fri, Apr 11, 2014 at 5:58 PM, Stephen Hemminger
<stephen@...workplumber.org> wrote:
> On Fri, 11 Apr 2014 17:45:53 -0700
> Cong Wang <xiyou.wangcong@...il.com> wrote:
>> It's already there:
>>
>>         } else if (sel && sel->flags&TC_U32_TERMINAL) {
>>                 fprintf(f, "terminal flowid ??? ");
>>         }
>
> But it printing it like an error, not an known good option.
> The ??? implies that somebody did something wrong.

I don't know why ??? is displayed together with terminal, but
nothing seems wrong here, check the output after I add
a mirred action:

filter protocol ip pref 49152 u32
filter protocol ip pref 49152 u32 fh 800: ht divisor 1
filter protocol ip pref 49152 u32 fh 800::800 order 2048 key ht 800
bkt 0 terminal flowid ???
  match 01020304/ffffffff at 16
action order 1: mirred (Egress Mirror to device virbr0) pipe
  index 1 ref 1 bind 1
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html