netdev - Re: [PATCH 3.2] ipv6: don't set DST_NOCOUNT for remotely added routes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1397432978.10849.92.camel@deadeye.wl.decadent.org.uk>
Date:	Mon, 14 Apr 2014 00:49:38 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	David Miller <davem@...emloft.net>
Cc:	stable@...r.kernel.org, sd@...asysnail.net,
	hannes@...essinduktion.org, netdev@...r.kernel.org
Subject: Re: [PATCH 3.2] ipv6: don't set DST_NOCOUNT for remotely added
 routes

On Sun, 2014-04-13 at 19:19 -0400, David Miller wrote:
> From: Ben Hutchings <ben@...adent.org.uk>
> Date: Mon, 14 Apr 2014 00:02:22 +0100
> 
> > From: Sabrina Dubroca <sd@...asysnail.net>
> > 
> > commit c88507fbad8055297c1d1e21e599f46960cbee39 upstream.
> > 
> > DST_NOCOUNT should only be used if an authorized user adds routes
> > locally. In case of routes which are added on behalf of router
> > advertisments this flag must not get used as it allows an unlimited
> > number of routes getting added remotely.
> > 
> > Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>
> > Acked-by: Hannes Frederic Sowa <hannes@...essinduktion.org>
> > Signed-off-by: David S. Miller <davem@...emloft.net>
> > [bwh: Backported to 3.2: adjust context]
> > Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> > ---
> > This is untested, but looks almost identical to what you sent for 3.4.
> > Please ack/nak.
> 
> This looks good to me:
> 
> Acked-by: David S. Miller <davem@...emloft.net>

Thanks, I've queued this up now.

Ben.

-- 
Ben Hutchings
I say we take off; nuke the site from orbit.  It's the only way to be sure.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)