netdev - Re: [PATCH] Revert "net: mvneta: fix usage as a module on RGMII configurations"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140413.231457.1275572148025135232.davem@davemloft.net>
Date:	Sun, 13 Apr 2014 23:14:57 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	thomas.petazzoni@...e-electrons.com
Cc:	netdev@...r.kernel.org, ezequiel.garcia@...e-electrons.com,
	gregory.clement@...e-electrons.com, jason@...edaemon.net,
	andrew@...n.ch, sebastian.hesselbarth@...il.com, alior@...vell.com,
	tawfik@...vell.com, linux-arm-kernel@...ts.infradead.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] Revert "net: mvneta: fix usage as a module on RGMII
 configurations"

From: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
Date: Sun, 13 Apr 2014 11:15:33 +0200

> This reverts commit e3a8786c10e75903f1269474e21fe8cb49c3a670. While
> this commit allows to use the mvneta driver as a module on some
> configurations, it breaks other configurations even if mvneta is used
> built-in.
> 
> This breakage is due to the fact that on some RGMII platforms, the PCS
> bit has to be set, and on some other platforms, it has to be
> cleared. At the moment, we lack informations to know exactly the
> significance of this bit (the datasheet only says "enables PCS"), and
> so we can't produce a patch that will work on all platforms at this
> point. And since this change is breaking the network completely for
> many users, it's much better to revert it for now. We'll come back
> later with a proper fix that takes into account all platforms.
> 
> Basically:
> 
>  * Armada XP GP is configured as RGMII-ID, and needs the PCS bit to be
>    set.
>  * Armada 370 Mirabox is configured as RGMII-ID, and needs the PCS bit
>    to be cleared.
> 
> And at the moment, we don't know how to make the distinction between
> those two cases. One hint is that the Armada XP GP appears in fact to
> be using a QSGMII connection with the PHY (Quad-SGMII), but
> configuring it as SGMII doesn't work, while RGMII-ID works. This needs
> more investigation, but in the mean time, let's unbreak the network
> for all those users.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
> Reported-by: Arnaud Ebalard <arno@...isbad.org>
> Reported-by: Alexander Reuter <Alexander.Reuter@....net>
> Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=73401

Applied, thanks for following up on this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html