netdev - Re: [PATCH v2] net IPv6: Remove unnecessary argument of ndisc_send_ns and ndisc_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140414.132201.372297856628816549.davem@davemloft.net>
Date:	Mon, 14 Apr 2014 13:22:01 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	kumaran.4353@...il.com
Cc:	kuznet@....inr.ac.ru, jmorris@...ei.org, kaber@...sh.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH v2] net IPv6: Remove unnecessary argument of
 ndisc_send_ns and ndisc_send_na

From: Balakumaran Kannan <kumaran.4353@...il.com>
Date: Mon, 14 Apr 2014 09:36:03 +0530

> The 'neigh' argument of 'ndisc_send_ns' and 'ndisc_send_na' are not used in
> these functions. So this argument could be removed.
> 
> And a minor change of 'optlen' assignment in those functions. the compound
> addition and assignment operator is not needed as 'optlen' value is always
> zero.
> 
> Signed-off-by: Balakumaran Kannan <kumaran.4353@...il.com>
> ---
> I am not sure whether 'neigh' argument is intentional or planned for any
> future use. If you find this is unnecessary, this patch could be considered.
> 
> And ndisc_send_na is used as a function pointer in ipv6_stub. This may affect
> anybody using this structure. But with default configuration built, I didn't
> get any error or warning. Kindly consider this scenario also.
> 
> Please ignore the previous patch as it doesn't have optlen modification in
> ndisc_send_na

I really don't like this change, and furthermore this breaks the build
as Hideaki YOSHIFUJI pointed out.  Drivers use the ipv6_stub methods and
you thus have to update all of the ones that use the ->ndisc_*().
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html