netdev - Re: [PATCH net] Revert "net: sctp: Fix a_rwnd/rwnd management to reflect real state of the receiver's buffer"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Apr 2014 10:46:03 +0200
From:	Alexander Sverdlin <alexander.sverdlin@....com>
To:	ext David Miller <davem@...emloft.net>, dborkman@...hat.com
CC:	netdev@...r.kernel.org, linux-sctp@...r.kernel.org,
	matija.glavinic-pecotic.ext@....com, vyasevich@...il.com
Subject: Re: [PATCH net] Revert "net: sctp: Fix a_rwnd/rwnd management to
 reflect real state of the receiver's buffer"

Hi!

On 14/04/14 22:48, ext David Miller wrote:
>> This reverts commit ef2820a735f7 ("net: sctp: Fix a_rwnd/rwnd management
>> to reflect real state of the receiver's buffer") as it introduced a
>> serious performance regression on SCTP over IPv4 and IPv6, though a not
>> as dramatic on the latter. Measurements are on 10Gbit/s with ixgbe NICs.
>>
>> Current state:
>  ...
>> With the reverted patch applied, the SCTP/IPv4 performance is back
>> to normal on latest upstream for IPv4 and IPv6 and has same throughput
>> as 3.4.2 test kernel, steady and interval reports are smooth again.
>>
>> Fixes: ef2820a735f7 ("net: sctp: Fix a_rwnd/rwnd management to reflect real state of the receiver's buffer")
>> Reported-by: Peter Butler <pbutler@...usnet.com>
>> Reported-by: Dongsheng Song <dongsheng.song@...il.com>
>> Reported-by: Fengguang Wu <fengguang.wu@...el.com>
>> Tested-by: Peter Butler <pbutler@...usnet.com>
>> Signed-off-by: Daniel Borkmann <dborkman@...hat.com>
> 
> Applied and queued up for -stable.

Should not this be fixed actually in SCTP congestion control part?
RWND calculation is actually not responsible for congestion control.
And this revert actually introduces serious bug again, which leads to SCTP being stuck completely in particular 
multi-homed use-cases (refer to http://www.spinics.net/lists/linux-sctp/msg02516.html).

We are not arguing against another version of the patch, but:
- you are choosing speed instead of stability here
- you are masking the problem reverting the code, which is not responsible for the problem observed

-- 
Best regards,
Alexander Sverdlin.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html