lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 15 Apr 2014 15:00:01 -0600 From: Stephen Warren <swarren@...dotorg.org> To: Chen-Yu Tsai <wens@...e.org>, Linus Walleij <linus.walleij@...aro.org>, Johannes Berg <johannes@...solutions.net>, "John W. Linville" <linville@...driver.com>, Maxime Ripard <maxime.ripard@...e-electrons.com> CC: Alexandre Courbot <gnurou@...il.com>, Heikki Krogerus <heikki.krogerus@...ux.intel.com>, Arnd Bergmann <arnd@...db.de>, devicetree@...r.kernel.org, netdev@...r.kernel.org, linux-sunxi@...glegroups.com, linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org, Mika Westerberg <mika.westerberg@...ux.intel.com>, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH 5/7] net: rfkill: gpio: add device tree support On 04/15/2014 12:41 AM, Chen-Yu Tsai wrote: Patch description? > diff --git a/Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt b/Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt > +Required properties: > +- gpios : At most two GPIO phandles > +- gpio-names : Shall be "reset" or "shutdown", matching gpios. > + If both are provided, the "reset" GPIO is toggled first. As Maxime mentioned, this is an unusual way of defining GPIOs. If this new way is acceptable, then I'd suggest more precise wording, e.g.: - gpios: Must contain an entry for each entry in gpio-names. See ../gpio/gpio.txt for details. - gpio-names: May contain any or all of the following entries: - reset - shutdown > +- rfkill-type : Type of RFKILL device: 1 for WiFi, 2 for BlueTooth, etc. > + See include/uapi/linux/rfkill.h for all valid values It would be nice if include/dt-bindings/rfkill-gpio.h existed and contained e.g.: #define RFKILL_TYPE_BLUETOOTH 2 So that: > +Example: > + > + rfkill_bt { ... > + rfkill-type = <2>; Could be written as: rfkill-type = <RFKILL_TYPE_BLUETOOTH>; -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists