netdev - Re: [Patch net] sched, cls: check if we could overwrite actions when changing a filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXRVZ8_keaL-8OkmRVguA29bnTPS2ZHZ0j2SSeB6A=1jQ@mail.gmail.com>
Date:	Wed, 16 Apr 2014 14:10:08 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Jamal Hadi Salim <jhs@...atatu.com>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Cong Wang <cwang@...pensource.com>
Subject: Re: [Patch net] sched, cls: check if we could overwrite actions when
 changing a filter

On Wed, Apr 16, 2014 at 5:30 AM, Jamal Hadi Salim <jhs@...atatu.com> wrote:
> On 04/15/14 19:46, Cong Wang wrote:
>>
>> From: Cong Wang <cwang@...pensource.com>
>>
>> When actions are attached to a filter, they are a part of the filter
>> itself, so when changing a filter we should allow to overwrite the actions
>> inside as well.
>>
>> In my specific case, when I tried to _append_ a new action to an existing
>> filter which already has an action, I got EEXIST since kernel refused
>> to overwrite the existing one in kernel.
>>
>> This patch checks if we are changing the filter checking NLM_F_CREATE flag
>> (Sigh, filters don't use NLM_F_REPLACE...) and then passes the boolean
>> down
>> to actions. This fixes the problem above.
>
>
>
> What are you trying to achieve?

I thought it's clear: I have a filter F1 contains an action A1,
they are already in kernel (therefore I can read them from libnl cache),
then I want to append A2 to F1 so that F1 would have two actions
A1 and A2.

In short: change from F1 -> A1 to F1 -> A1 -> A2 atomically.

> These are general netlink rules (which can be streamlined by
> the object).
> Append means "I dont care if this exists, add it to the end"

Exactly what I meant.

> In that case, you would specify the an existing filter rule but
> in order to resolve ambiguity tc classifiers provide priorities
> (i.e just specify a different priority) and the rule will be added
> before or after  the conflicting rule.
> If you dont do that then you will get back EEXIST to tell you
> there is a conflict.

But I already told kernel I am changing a filter, so why it
complains? I should change an existing one, shouldn't I?

> You cant replace an existing filter in particular when it has
> a graph of actions attached to it. You can replace the paremetrization
> of an existing bound action - but i am not sure that is what you
> are trying to do here. For that address the specific action directly.
> i.e tc action ....

Why? Since actions are inside it, I should be able to change any
part of it, right?

> If otoh you wanted to replace the filter + action graph with a backup
> rule, then just add it lower in the priority list and delete the
> existing one etc.
>

This is not atomic, is it?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html