lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 16 Apr 2014 14:30:49 +0800
From:	"Li, ZhenHua" <>
To:	David Miller <>
Subject: Re: [PATCH 1/1] driver/net: add missing rtnl lock/unlock for benet

Hi David,

I think you are right. I checked other NIC drivers, found some of them 
call rtnl_lock and rtnl_unlock around netif_device_detach and attach 
functions, while some drivers did not.

I will create a new patch in generic way to fix this.

On 04/16/2014 03:09 AM, David Miller wrote:
> From: "Li, Zhen-Hua" <>
> Date: Tue, 15 Apr 2014 14:45:52 +0800
>> From: "Li, Zhen-Hua" <>
>> In benet driver, netif_device_detach and netif_device_attach should be
>> called between rtnl_lock and rtnl_unlock.
>> Signed-off-by: Li, Zhen-Hua <>
> This absolutely does not look like a driver specific issue, therefore
> I do not want you to make such locking context adjustments only in
> your driver.
> Do it somewhere generic so that every driver gets the fix, not just
> your driver.

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists