lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 16 Apr 2014 17:20:44 +0300 From: Amir Vadai <amirv@...lanox.com> To: Chris Mason <clm@...com>, <netdev@...r.kernel.org> Subject: Re: [PATCH] mlx4_en: don't use napi_synchronize inside mlx4_en_netpoll On 4/16/2014 1:09 AM, Chris Mason wrote: > > > The mlx4 driver is triggering schedules while atomic inside > mlx4_en_netpoll: > > spin_lock_irqsave(&cq->lock, flags); > napi_synchronize(&cq->napi); > ^^^^^ msleep here > mlx4_en_process_rx_cq(dev, cq, 0); > spin_unlock_irqrestore(&cq->lock, flags); > > This was part of a patch by Alexander Guller from Mellanox in 2011, > but it still isn't upstream. > > Signed-off-by: Chris Mason <clm@...com> > cc: stable@...r.kernel.org > --- > drivers/net/ethernet/mellanox/mlx4/en_cq.c | 1 - > drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 6 +----- > drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 1 - > 3 files changed, 1 insertion(+), 7 deletions(-) > Acked-By: Amir Vadai <amirv@...lanox.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists