netdev - Re: [PATCH net v3] sfc:On MCDI timeout, issue an FLR (and mark MCDI to fail-fast)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140416.143503.820604109876720374.davem@davemloft.net>
Date:	Wed, 16 Apr 2014 14:35:03 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	sshah@...arflare.com
Cc:	netdev@...r.kernel.org, linux-net-drivers@...arflare.com,
	rstonehouse@...arflare.com
Subject: Re: [PATCH net v3] sfc:On MCDI timeout, issue an FLR (and mark
 MCDI to fail-fast)

From: Shradha Shah <sshah@...arflare.com>
Date: Wed, 16 Apr 2014 19:27:48 +0100

> From: Edward Cree <ecree@...arflare.com>
> 
> When an MCDI command times out (whether or not we find it
> completed when we poll), call efx_mcdi_abandon(), which tells
> all subsequent MCDI calls to fail-fast, and queues up an FLR.
> 
> Because an FLR doesn't lead to receiving any reboot even from
> the MC (unlike most other types of reset), we have to call
> efx_ef10_reset_mc_allocations.
> In efx_start_all(), if a reset (of any kind) is pending, we
> bail out.
> Without this, attempts to reconfigure (e.g. change mtu) can
> cause driver/mc state inconsistency if the first MCDI call
> triggers an FLR.
> 
> For similar reasons, on EF10, in
> efx_reset_down(method=RESET_TYPE_MCDI_TIMEOUT), set the number
> of active queues to zero before calling efx_stop_all().
> And, on farch, in efx_reset_up(method=RESET_TYPE_MCDI_TIMEOUT),
> set active_queues and flushes pending & outstanding to zero.
> 
> efx_mcdi_mode_{poll,event}() should not take us out of fail-fast
>  mode. Instead, this is done by efx_mcdi_reset() after the FLR
> completes.
> 
> The new FLR reset_type RESET_TYPE_MCDI_TIMEOUT doesn't really
> fit into the hierarchy of reset 'scopes' whereby efx_reset()
> decides some resets subsume others.  Thus, it uses separate logic.
> 
> Also, fixed up some inconsistency around RESET_TYPE_MC_BIST,
> which was in the wrong place in that hierarchy.
> 
> Signed-off-by: Shradha Shah <sshah@...arflare.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html