netdev - Re: [PATCH] net: c_can: Add support for D

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1397745415.31413.2.camel@dinh-ubuntu>
Date:	Thu, 17 Apr 2014 09:36:55 -0500
From:	Thor Thayer <tthayer@...era.com>
To:	Thomas Gleixner <tglx@...utronix.de>
CC:	<linux-can@...r.kernel.org>, <wg@...ndegger.com>,
	<mkl@...gutronix.de>, <socketcan@...tkopp.net>, <anilkumar@...com>,
	<tthayer.linux@...il.com>, "David S. Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: c_can: Add support for D_CAN module RAM Init.

On Wed, 2014-04-16 at 23:13 +0200, Thomas Gleixner wrote:
> 
> On Wed, 16 Apr 2014, tthayer@...era.com wrote:
> 
> > From: Thor Thayer <tthayer@...era.com>
> > 
> > The D_CAN driver was written to support the TI D_CAN implementation
> > which placed the D_CAN RAM reset in a separate register. In the
> > standard D_CAN module the RAM Init is in the D_CAN module so
> > handle the RAM Init differently.
> > +		if (!res) {
> > +			priv->raminit = c_can_hw_raminit;
> > +			priv->raminit_type_flag = 0;
> 
> Can we please make that raminit_type and use proper constants?
> 
> Thanks,
> 
> 	tglx

Yes. I will make these changes. Thanks for reviewing.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html