netdev - RE: [PATCH] net: sxgbe: make local functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <000501cf5afa$4f401f80$edc05e80$%an@samsung.com>
Date:	Fri, 18 Apr 2014 20:35:33 +0900
From:	Byungho An <bh74.an@...sung.com>
To:	'Jingoo Han' <jg1.han@...sung.com>, netdev@...r.kernel.org,
	'David Miller' <davem@...emloft.net>
Cc:	'Girish K S' <ks.giri@...sung.com>,
	'Siva Reddy Kallam' <siva.kallam@...sung.com>,
	'Vipul Pandya' <vipul.pandya@...sung.com>
Subject: RE: [PATCH] net: sxgbe: make local functions static

Jingoo Han wrote:
> 
> Make local functions static, because these are used only in this
> file.
> 
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>

Acked-by: Byungho An <bh74.an@...sung.com>

> ---
>  drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c |   15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
> b/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
> index a72688e..dbb0abb 100644
> --- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
> +++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
> @@ -425,8 +425,8 @@ dmamem_err:
>   * @rx_rsize: ring size
>   * Description:  this function initializes the DMA RX descriptor
>   */
> -void free_rx_ring(struct device *dev, struct sxgbe_rx_queue *rx_ring,
> -		  int rx_rsize)
> +static void free_rx_ring(struct device *dev, struct sxgbe_rx_queue
> *rx_ring,
> +			 int rx_rsize)
>  {
>  	dma_free_coherent(dev, rx_rsize * sizeof(struct sxgbe_rx_norm_desc),
>  			  rx_ring->dma_rx, rx_ring->dma_rx_phy);
> @@ -519,8 +519,8 @@ error:
>   * @tx_rsize: ring size
>   * Description:  this function initializes the DMA TX descriptor
>   */
> -void free_tx_ring(struct device *dev, struct sxgbe_tx_queue *tx_ring,
> -		  int tx_rsize)
> +static void free_tx_ring(struct device *dev, struct sxgbe_tx_queue
> *tx_ring,
> +			 int tx_rsize)
>  {
>  	dma_free_coherent(dev, tx_rsize * sizeof(struct sxgbe_tx_norm_desc),
>  			  tx_ring->dma_tx, tx_ring->dma_tx_phy);
> @@ -1218,11 +1218,10 @@ static int sxgbe_release(struct net_device *dev)
> 
>  	return 0;
>  }
> -
>  /* Prepare first Tx descriptor for doing TSO operation */
> -void sxgbe_tso_prepare(struct sxgbe_priv_data *priv,
> -		       struct sxgbe_tx_norm_desc *first_desc,
> -		       struct sk_buff *skb)
> +static void sxgbe_tso_prepare(struct sxgbe_priv_data *priv,
> +			      struct sxgbe_tx_norm_desc *first_desc,
> +			      struct sk_buff *skb)
>  {
>  	unsigned int total_hdr_len, tcp_hdr_len;
> 
> --
> 1.7.10.4
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html