netdev - Re: [PATCH net v4] vlan: Fix lockdep warning when vlan dev handle notification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140418.174955.2251431485153794486.davem@davemloft.net>
Date:	Fri, 18 Apr 2014 17:49:55 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dingtianhong@...wei.com
Cc:	ben@...adent.org.uk, john.r.fastabend@...el.com, kaber@...sh.net,
	netdev@...r.kernel.org, f.fainelli@...il.com
Subject: Re: [PATCH net v4] vlan: Fix lockdep warning when vlan dev handle
 notification

From: Ding Tianhong <dingtianhong@...wei.com>
Date: Thu, 17 Apr 2014 18:40:36 +0800

> When I open the LOCKDEP config and run these steps:
> 
> modprobe 8021q
> vconfig add eth2 20
> vconfig add eth2.20 30
> ifconfig eth2 xx.xx.xx.xx
> 
> then the Call Trace happened:
...
> The reason is that all of the addr_lock_key for vlan dev have the same class,
> so if we change the status for vlan dev, the vlan dev and its real dev will
> hold the same class of addr_lock_key together, so the warning happened.
> 
> we should distinguish the lock depth for vlan dev and its real dev.
...
> Signed-off-by: Ding Tianhong <dingtianhong@...wei.com>

Looks good, applied and queued up for -stable, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html