diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c index 101db3f..5ae1844 100644 --- a/drivers/virtio/virtio_pci.c +++ b/drivers/virtio/virtio_pci.c @@ -62,6 +62,8 @@ struct virtio_pci_device /* Whether we have vector per vq */ bool per_vq_vectors; + + char config_msix_name[256]; }; /* Constants for MSI-X */ @@ -302,6 +304,8 @@ static void vp_free_vectors(struct virtio_device *vdev) vp_dev->msix_affinity_masks = NULL; } +static struct msix_entry *config_msix_entry; +static char *config_msix_name; static int vp_request_msix_vectors(struct virtio_device *vdev, int nvectors, bool per_vq_vectors) { @@ -309,9 +313,14 @@ static int vp_request_msix_vectors(struct virtio_device *vdev, int nvectors, const char *name = dev_name(&vp_dev->vdev.dev); unsigned i, v; int err = -ENOMEM; + int has_config_msix = 1; - vp_dev->msix_vectors = nvectors; + if (!config_msix_entry) { + has_config_msix = 0; + nvectors += 1; + } + vp_dev->msix_vectors = nvectors; vp_dev->msix_entries = kmalloc(nvectors * sizeof *vp_dev->msix_entries, GFP_KERNEL); if (!vp_dev->msix_entries) @@ -341,14 +350,24 @@ static int vp_request_msix_vectors(struct virtio_device *vdev, int nvectors, /* Set the vector used for configuration */ v = vp_dev->msix_used_vectors; - snprintf(vp_dev->msix_names[v], sizeof *vp_dev->msix_names, + + if (has_config_msix == 0) { + config_msix_entry = &vp_dev->msix_entries[v]; + config_msix_name = vp_dev->msix_names[v]; + } else { + config_msix_name = vp_dev->config_msix_name; + } + + snprintf(vp_dev->config_msix_name, sizeof *vp_dev->msix_names, "%s-config", name); - err = request_irq(vp_dev->msix_entries[v].vector, - vp_config_changed, 0, vp_dev->msix_names[v], - vp_dev); + err = request_irq(config_msix_entry->vector, + vp_config_changed, IRQF_SHARED, + vp_dev->config_msix_name, vp_dev); if (err) goto error; - ++vp_dev->msix_used_vectors; + + if (has_config_msix == 0) + ++vp_dev->msix_used_vectors; iowrite16(v, vp_dev->ioaddr + VIRTIO_MSI_CONFIG_VECTOR); /* Verify we had enough resources to assign the vector */ @@ -536,13 +555,13 @@ static int vp_try_to_find_vqs(struct virtio_device *vdev, unsigned nvqs, } else { if (per_vq_vectors) { /* Best option: one for change interrupt, one per vq. */ - nvectors = 1; + nvectors = 0; for (i = 0; i < nvqs; ++i) if (callbacks[i]) ++nvectors; } else { /* Second best: one for change, shared for all vqs. */ - nvectors = 2; + nvectors = 1; } err = vp_request_msix_vectors(vdev, nvectors, per_vq_vectors);