lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 19 Apr 2014 10:43:17 -0400 From: Mike Frysinger <vapier@...too.org> To: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org> Cc: netdev@...r.kernel.org, David Heidelberger <david.heidelberger@...t.cz> Subject: [PATCH [iputils] 5/5] tftpd: check return value of set*id calls Signed-off-by: Mike Frysinger <vapier@...too.org> --- tftpd.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tftpd.c b/tftpd.c index 2a39ec4..6519de3 100644 --- a/tftpd.c +++ b/tftpd.c @@ -109,17 +109,20 @@ int main(int ac, char **av) register int n = 0; int on = 1; + openlog("tftpd", LOG_PID, LOG_DAEMON); + /* Sanity. If parent forgot to setuid() on us. */ if (geteuid() == 0) { - setgid(65534); - setuid(65534); + if (setgid(65534) || setuid(65534)) { + syslog(LOG_ERR, "set*id failed: %m\n"); + exit(1); + } } ac--; av++; while (ac-- > 0 && n < MAXARG) dirs[n++] = *av++; - openlog("tftpd", LOG_PID, LOG_DAEMON); if (ioctl(0, FIONBIO, &on) < 0) { syslog(LOG_ERR, "ioctl(FIONBIO): %m\n"); exit(1); -- 1.9.2 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists