netdev - Re: [PATCH] virtio_net: zero is an invald queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 21 Apr 2014 14:45:25 +0800
From:	Jason Wang <jasowang@...hat.com>
To:	Amos Kong <akong@...hat.com>,
	virtualization@...ts.linux-foundation.org
CC:	netdev@...r.kernel.org, mst@...hat.com
Subject: Re: [PATCH] virtio_net: zero is an invald queue_pairs number

On 04/21/2014 02:32 PM, Jason Wang wrote:
> On 04/18/2014 01:45 PM, Amos Kong wrote:
>> Execute "ethtool -L eth0 combined 0" in guest, if multiqueue
>> is enabled, virtnet_send_command() will return -EINVAL error,
>> there is a validation in QEMU.
>>
>> But if multiqueue is disabled, virtnet_set_queues() will just
>> return zero (success). We should return error for this situation.
>>
>> Signed-off-by: Amos Kong <akong@...hat.com>
>> ---
>>  drivers/net/virtio_net.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
>> index 7b68746..8a852b5 100644
>> --- a/drivers/net/virtio_net.c
>> +++ b/drivers/net/virtio_net.c
>> @@ -1285,7 +1285,7 @@ static int virtnet_set_channels(struct net_device *dev,
>>  	if (channels->rx_count || channels->tx_count || channels->other_count)
>>  		return -EINVAL;
>>  
>> -	if (queue_pairs > vi->max_queue_pairs)
>> +	if (queue_pairs > vi->max_queue_pairs || queue_pairs == 0)
>>  		return -EINVAL;
>>  
>>  	get_online_cpus();
> Acked-by:  Jason Wang <jasowang@...hat.com>

Looking at virtnet_set_queues(), it will return success even if no cvq
and no mq support. This is wrong. We need return error in this case.
We'd better fix it and check the its return value in virtnet_restore().

With this fix, there's no need for us to check queue_pairs against zero
like what this patch does.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html