netdev - Re: [PATCH net-next 1/4] net: systemport: add Broadcom SYSTEMPORT Ethernet MAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGVrzcbCLHCgFZGTTtCUaDHLcWh5RvwCj0VyUDK6=8hbPrV2Vg@mail.gmail.com>
Date:	Mon, 21 Apr 2014 10:51:05 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/4] net: systemport: add Broadcom SYSTEMPORT
 Ethernet MAC driver

2014-04-21 10:46 GMT-07:00 David Miller <davem@...emloft.net>:
> From: Florian Fainelli <f.fainelli@...il.com>
> Date: Mon, 21 Apr 2014 10:31:31 -0700
>
>> +#ifdef CONFIG_PHYS_ADDR_T_64BIT
>> +     __raw_writel(upper_32_bits(addr) & DESC_ADDR_HI_MASK,
>> +                             d + DESC_ADDR_HI_STATUS_LEN);
>> +#endif
>
> When a function call spans multiple lines, the arguments on the second
> and subsequent lines need to start exactly at the first column after
> the openning parenthesis.
>
> Please audit and fix this in your entire submission.
>
>> +static int bcm_sysport_set_settings(struct net_device *dev,
>> +                                 struct ethtool_cmd *cmd)
>
> Likewise for functions declarations and definitions.
>
> Also, no NAPI support?  The locking and SKB freeing looks quite baroque
> as a consequence of this.

There is NAPI support for the RX path, transmitted SKBs are freed when
the buffer done interrupt fires, I can certainly rework that if you
feel like it would be better to get per tx-queue NAPI contexts
instead.

Thanks!
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html