netdev - Re: [PATCH ethtool 2/2] Use htobe64, htobe16 from libc instead of local byteswap code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 21 Apr 2014 22:18:48 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Cristian Rodríguez <crrodriguez@...nsuse.org>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH ethtool 2/2] Use htobe64, htobe16 from libc instead of
 local byteswap code

On Thu, 2014-04-03 at 00:06 -0300, Cristian Rodríguez wrote:
> They are implemented in <endian.h> which is already included
> in internal.h, no need to reinvent them with different names.
> 
> Signed-off-by: Cristian Rodríguez <crrodriguez@...nsuse.org>
[...]

According to the manual page, "These functions were added to glibc in
version 2.9."

Which is quite old now, but newer than several supported distributions
(e.g. RHEL 5).  So we would need an autoconf test and fallback
definition, at which point there doesn't seem to be any benefit.

Ben.

-- 
Ben Hutchings
Knowledge is power.  France is bacon.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)