netdev - Re: [PATCH] netprio_cgroup: explicitly init the early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140422.121315.929124038777369470.davem@davemloft.net>
Date:	Tue, 22 Apr 2014 12:13:15 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	nasa4836@...il.com
Cc:	nhorman@...driver.com, tj@...nel.org, daniel.wagner@...-carit.de,
	gaofeng@...fujitsu.com, stephen@...workplumber.org,
	jiri@...nulli.us, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netprio_cgroup: explicitly init the early_init field

From: Jianyu Zhan <nasa4836@...il.com>
Date: Tue, 22 Apr 2014 19:25:41 +0800

> I don't think that the value of one field(early_init) has a so subtle
> restrition on the another field(css_alloc) is a good thing, but since
> it is there, docment it should be needed.

This is not a reasonable change.

We depend upon implicit initialization to zero all over the kernel,
and adding explicit assignments hurts rather then helps.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html